GHSA-7vw7-qx38-37vr
GHSA-7vw7-qx38-37vr · Propel2 SQL injection possible with limit() on MySQL
This page contains facts from public vulnerability sources. Check the original advisory before updating.
The limit() query method is susceptible to catastrophic SQL injection with MySQL. For example, given a model User for a table users: ``` UserQuery::create()->limit('1;DROP TABLE users')->find(); ``` This will drop the users table! The cause appears to be a lack of integer casting of the limit input in either Propel\Runtime\ActiveQuery\Criteria::setLimit() or in Propel\Runtime\Adapter\Pdo\MysqlAdapter::applyLimit(). The code comments there seem to imply that casting was avoided due to overflow issues with 32-bit integers. This is surprising behavior since one of the primary purposes of an ORM is to prevent basic SQL injection. This affects all versions of Propel: 1.x, 2.x, and 3.
CVSS 9.8 · Critical · Fix available
- Published
- Updated
Stack: php
Affected products and versions
propel/propel Packagist
- Versions
- 2.0.0-alpha1
- 2.0.0-alpha2
- 2.0.0-alpha3
- 2.0.0-alpha4
- 2.0.0-alpha5
- 2.0.0-alpha6
- 2.0.0-alpha7
- Affected ranges
- ECOSYSTEM: ≥ 2.0.0-alpha1, < 2.0.0-alpha8
Update to 2.0.0-alpha8
Original sources
- https://github.com/propelorm/Propel2/issues/1463
- https://github.com/propelorm/Propel2/pull/1464
- https://github.com/propelorm/Propel2/commit/cd23d7384a15cfe203e23b3a835c8ab1d81d9246
- https://github.com/FriendsOfPHP/security-advisories/blob/master/propel/propel/2018-02-14.yaml
- https://github.com/propelorm/Propel2
- https://osv.dev/vulnerability/GHSA-7vw7-qx38-37vr